From: Alexander Graf <agraf@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Naphtali Sprei <nsprei@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Sheng Yang <sheng@linux.intel.com>
Subject: Re: [Qemu-devel] Re: [PATCH] block: Enable fall-back to read-only for backing file
Date: Mon, 01 Feb 2010 11:05:11 +0100 [thread overview]
Message-ID: <4B66A757.4020707@suse.de> (raw)
In-Reply-To: <20100201092756.GA21616@lst.de>
Christoph Hellwig wrote:
> On Mon, Feb 01, 2010 at 10:25:52AM +0100, Alexander Graf wrote:
>
>> We don't know beforehand if a user will use the commit comnand during
>> tje runtime of the vm.
>>
>> IMHO it'd be best to always open backing files read only and try to
>> open them for write access on the commit command. That command can
>> then fail gaciously.
>>
>
> That's another option. Basically this means opening another
> BlockDriverState for the backing device that is writeable inside
> bdrv_commit().
>
Or another function call hook to change the backing device state from RO
to RW.
Alex
next prev parent reply other threads:[~2010-02-01 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 16:49 [Qemu-devel] [PATCH] block: Enable fall-back to read-only for backing file Naphtali Sprei
2010-02-01 8:46 ` [Qemu-devel] " Kevin Wolf
2010-02-01 9:06 ` Christoph Hellwig
2010-02-01 9:25 ` Alexander Graf
2010-02-01 9:27 ` Christoph Hellwig
2010-02-01 10:05 ` Alexander Graf [this message]
2010-02-01 12:32 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B66A757.4020707@suse.de \
--to=agraf@suse.de \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).