From: Kevin Wolf <kwolf@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [RFC 0/2]: QMP DISK_ERROR event
Date: Tue, 02 Feb 2010 13:19:06 +0100 [thread overview]
Message-ID: <4B68183A.3020407@redhat.com> (raw)
In-Reply-To: <20100202101723.291a57f2@doriath>
Am 02.02.2010 13:17, schrieb Luiz Capitulino:
>>> 3. Is this the right approach at all? :)
>>
>> Yes and no. As I said above, drive_get_on_error() is not the right place
>> to do it. Unfortunately it looks like there isn't a single generic place
>> where it can be done, but the call to the event handler must be added to
>> every device.
>
> Can't it be added to subsystems? Like ide, virtio etc?
>
> Maybe in the same function that calls driver_get_on_error()?
This is what I meant by devices, yes. Putting it into the same function
sounds good, too.
Kevin
prev parent reply other threads:[~2010-02-02 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 18:07 [Qemu-devel] [RFC 0/2]: QMP DISK_ERROR event Luiz Capitulino
2010-02-01 18:07 ` [Qemu-devel] [PATCH 1/2] block: Introduce drive_get_err_action() Luiz Capitulino
2010-02-01 18:07 ` [Qemu-devel] [PATCH 2/2] QMP: Introduce DISK_ERROR event Luiz Capitulino
2010-02-02 9:30 ` [Qemu-devel] " Kevin Wolf
2010-02-02 9:25 ` [Qemu-devel] Re: [RFC 0/2]: QMP " Kevin Wolf
2010-02-02 12:17 ` Luiz Capitulino
2010-02-02 12:19 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B68183A.3020407@redhat.com \
--to=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).