From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NcHkB-0000Gs-P1
	for qemu-devel@nongnu.org; Tue, 02 Feb 2010 07:20:35 -0500
Received: from [199.232.76.173] (port=60788 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NcHkB-0000GX-8u
	for qemu-devel@nongnu.org; Tue, 02 Feb 2010 07:20:35 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kwolf@redhat.com>) id 1NcHjc-0006F5-MO
	for qemu-devel@nongnu.org; Tue, 02 Feb 2010 07:20:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4939)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1NcHjb-0006E9-WA
	for qemu-devel@nongnu.org; Tue, 02 Feb 2010 07:20:00 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o12CJwNB020351
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Feb 2010 07:19:59 -0500
Message-ID: <4B68183A.3020407@redhat.com>
Date: Tue, 02 Feb 2010 13:19:06 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1265047668-15039-1-git-send-email-lcapitulino@redhat.com>	<4B67EF7F.8060308@redhat.com>
	<20100202101723.291a57f2@doriath>
In-Reply-To: <20100202101723.291a57f2@doriath>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC 0/2]: QMP DISK_ERROR event
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Am 02.02.2010 13:17, schrieb Luiz Capitulino:
>>> 3. Is this the right approach at all? :)
>>
>> Yes and no. As I said above, drive_get_on_error() is not the right place
>> to do it. Unfortunately it looks like there isn't a single generic place
>> where it can be done, but the call to the event handler must be added to
>> every device.
> 
>  Can't it be added to subsystems? Like ide, virtio etc?
> 
>  Maybe in the same function that calls driver_get_on_error()?

This is what I meant by devices, yes. Putting it into the same function
sounds good, too.

Kevin