From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NcbOW-0000yo-V3 for qemu-devel@nongnu.org; Wed, 03 Feb 2010 04:19:33 -0500 Received: from [199.232.76.173] (port=34319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NcbOW-0000yd-Et for qemu-devel@nongnu.org; Wed, 03 Feb 2010 04:19:32 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NcbOV-0001PW-3n for qemu-devel@nongnu.org; Wed, 03 Feb 2010 04:19:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48945) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NcbOU-0001P8-Km for qemu-devel@nongnu.org; Wed, 03 Feb 2010 04:19:30 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o139JTnr024094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Feb 2010 04:19:29 -0500 Message-ID: <4B693F6D.5090300@redhat.com> Date: Wed, 03 Feb 2010 10:18:37 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1265145013-23231-1-git-send-email-lcapitulino@redhat.com> <1265145013-23231-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1265145013-23231-2-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Am 02.02.2010 22:10, schrieb Luiz Capitulino: > This commit adds the basic definitions for the BLOCK_IO_ERROR > event, but actual event emission will be introduced by the > next commits. > > NOTE: Adding a small reference in QMP/qmp-events.txt, but this > file is wrong and will be replaced by proper documentation shortly. > > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 7 +++++++ > monitor.c | 3 +++ > monitor.h | 1 + > 3 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index dc48ccc..7886192 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -43,3 +43,10 @@ Data: 'server' and 'client' keys with the same keys as 'query-vnc'. > > Description: Issued when the VNC session is made active. > Data: 'server' and 'client' keys with the same keys as 'query-vnc'. > + > +7 BLOCK_IO_ERROR > +---------------- > + > +Description: Issued when a disk I/O error occurs > +Data: 'device' (device name), 'action' (action to be taken), > + 'operation' ("read" or "write") I think we should document what allowed values for action are and what their meaning is. And isn't it actually "action that has been taken"? Kevin