From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NckIx-00016g-62
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:50:23 -0500
Received: from [199.232.76.173] (port=40609 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NckIw-00016S-Nn
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:50:22 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NckIs-00025S-FV
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:50:22 -0500
Received: from mail-yx0-f189.google.com ([209.85.210.189]:39597)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NckIs-00025I-5w
	for qemu-devel@nongnu.org; Wed, 03 Feb 2010 13:50:18 -0500
Received: by yxe27 with SMTP id 27so1419277yxe.4
	for <qemu-devel@nongnu.org>; Wed, 03 Feb 2010 10:50:17 -0800 (PST)
Message-ID: <4B69C565.9020006@codemonkey.ws>
Date: Wed, 03 Feb 2010 12:50:13 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Use QERR_INVALID_PARAMETER
	instead of QERR_INVALID_CPU_INDEX
References: <1264757641-29471-1-git-send-email-armbru@redhat.com>
	<1264757641-29471-2-git-send-email-armbru@redhat.com>
In-Reply-To: <1264757641-29471-2-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/29/2010 03:34 AM, Markus Armbruster wrote:
> This changes the error message from "Invalid CPU index" to "Invalid
> parameter index" in the human monitor.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
>    

Applied both.  Thanks.

Regards,

Anthony Liguori

> ---
>   monitor.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index fb7c572..69ebac5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -897,7 +897,7 @@ static void do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
>   {
>       int index = qdict_get_int(qdict, "index");
>       if (mon_set_cpu(index)<  0)
> -        qemu_error_new(QERR_INVALID_CPU_INDEX);
> +        qemu_error_new(QERR_INVALID_PARAMETER, "index");
>   }
>
>   static void do_info_jit(Monitor *mon)
>