From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nd6wM-0003e1-W0
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 14:00:35 -0500
Received: from [199.232.76.173] (port=38185 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nd6wL-0003df-KE
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 14:00:33 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <jan.kiszka@siemens.com>) id 1Nd6wI-0000Oc-8R
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 14:00:33 -0500
Received: from thoth.sbs.de ([192.35.17.2]:22435)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1Nd6wH-0000OE-Mk
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 14:00:30 -0500
Message-ID: <4B6B194A.90009@siemens.com>
Date: Thu, 04 Feb 2010 20:00:26 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1265232578.git.jan.kiszka@siemens.com>
	<372238c800e0d57815f472502fdf78e53463bbb6.1265232579.git.jan.kiszka@siemens.com>
	<20100203234929.GA11012@amt.cnet> <4B6A15EE.4050501@web.de>
	<20100204130038.GA15671@amt.cnet>
	<4B6AE1E6.9040805@siemens.com> <4B6AEAB8.3030509@siemens.com>
	<20100204180555.GA3861@amt.cnet> <4B6B179A.3080704@siemens.com>
In-Reply-To: <4B6B179A.3080704@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state
	writing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

Jan Kiszka wrote:
> Marcelo Tosatti wrote:
>>
>> Unrelated to this problem, won't put_vcpu_events, which is executed 
>> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
> 
> Good point, SET_GUEST_DEBUG should be last in the writeback for that reason.

Actually, we no longer need the exception injection via SET_GUEST_DEBUG
now that we have full access via vcpu_events. So this needs a cleanup,
and I'm afraid quite a few cases are broken ATM with vcpu_events
writeback overwriting the reinjected exceptions.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux