From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API
Date: Sun, 07 Feb 2010 16:32:27 +0200 [thread overview]
Message-ID: <4B6ECEFB.4050902@redhat.com> (raw)
In-Reply-To: <4B6ECD80.6090407@web.de>
On 02/07/2010 04:26 PM, Jan Kiszka wrote:
>
>> Well, to me it makes more sense to name them from the point of view of
>> the vcpu that is doing the update.
>>
> I'm open for a better name - except for "sync" as writebacks are always
> synchronous from the POV of the modified VCPU.
I meant that the state itself is synchronous from the POV of the vcpu.
That is, rax can only be changed by the core, but INIT state may be
changed by the other cores.
> Is KVM_PUT_RUNTIME_STATE
> clearer?
>
They're all runtime. I guess this issue will always be confusing, so
best to slap a comment on top of the define to explain it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-02-07 14:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 8:53 [Qemu-devel] [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 01/21] qemu-kvm: Drop vmport changes Jan Kiszka
2010-02-07 13:17 ` [Qemu-devel] " Avi Kivity
2010-02-07 13:54 ` Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 02/21] KVM: Make vmport KVM-compatible Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 03/21] qemu-kvm: Clean up register access API Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 04/21] KVM: x86: Fix up misreported CPU features Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 05/21] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 06/21] qemu-kvm: Use upstream kvm_setup_guest_memory Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 07/21] qemu-kvm: Use some more upstream prototypes Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 08/21] qemu-kvm: Use upstream kvm_arch_get_supported_cpuid Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 09/21] qemu-kvm: Use upstream kvm_pit_in_kernel Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 10/21] KVM: Move and rename regs_modified Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 11/21] KVM: Rework of guest debug state writing Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 12/21] qemu-kvm: Use upstream kvm_vcpu_dirty Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 13/21] qemu-kvm: Use upstream guest debug code Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API Jan Kiszka
2010-02-07 13:34 ` [Qemu-devel] " Avi Kivity
2010-02-07 13:51 ` Jan Kiszka
2010-02-07 13:58 ` Avi Kivity
2010-02-07 14:26 ` Jan Kiszka
2010-02-07 14:32 ` Avi Kivity [this message]
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 15/21] qemu-kvm: Clean up mpstate synchronization Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 16/21] KVM: x86: Restrict writeback of VCPU state Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 17/21] qemu-kvm: Use VCPU event state for reset and vmsave/load Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 18/21] qemu-kvm: Cleanup/fix TSC and PV clock writeback Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 19/21] qemu-kvm: Clean up KVM's APIC hooks Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 20/21] qemu-kvm: Move kvm_set_boot_cpu_id Jan Kiszka
2010-02-03 8:53 ` [Qemu-devel] [PATCH v2 21/21] qemu-kvm: Bring qemu_init_vcpu back home Jan Kiszka
2010-02-03 16:50 ` [Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Marcelo Tosatti
2010-02-03 18:02 ` Jan Kiszka
2010-02-03 18:36 ` Marcelo Tosatti
2010-02-04 7:17 ` Gleb Natapov
2010-02-04 8:18 ` [Qemu-devel] Need QEMU source and documentation Taimoor Mirza
2010-02-04 9:40 ` Roy Tam
2010-02-04 14:12 ` Anthony Liguori
2010-02-07 9:46 ` [Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code Gleb Natapov
2010-02-07 11:28 ` Jan Kiszka
2010-02-07 11:51 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6ECEFB.4050902@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).