From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ne8Bb-0006Oq-Kx
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 09:32:31 -0500
Received: from [199.232.76.173] (port=54233 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ne8Bb-0006O2-5Z
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 09:32:31 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1Ne8Ba-0000GC-DQ
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 09:32:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29486)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Ne8BZ-0000Fd-W0
	for qemu-devel@nongnu.org; Sun, 07 Feb 2010 09:32:30 -0500
Message-ID: <4B6ECEFB.4050902@redhat.com>
Date: Sun, 07 Feb 2010 16:32:27 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1265187223.git.jan.kiszka@siemens.com>
	<4822161334c3e10d7772dbd08dafdd3a78c86ce4.1265187223.git.jan.kiszka@siemens.com>
	<4B6EC180.7000203@redhat.com> <4B6EC557.9090804@web.de>
	<4B6EC6EC.4020509@redhat.com> <4B6ECD80.6090407@web.de>
In-Reply-To: <4B6ECD80.6090407@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state
	writeback API
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 02/07/2010 04:26 PM, Jan Kiszka wrote:
>
>> Well, to me it makes more sense to name them from the point of view of
>> the vcpu that is doing the update.
>>      
> I'm open for a better name - except for "sync" as writebacks are always
> synchronous from the POV of the modified VCPU.

I meant that the state itself is synchronous from the POV of the vcpu.  
That is, rax can only be changed by the core, but INIT state may be 
changed by the other cores.

>   Is KVM_PUT_RUNTIME_STATE
> clearer?
>    

They're all runtime.  I guess this issue will always be confusing, so 
best to slap a comment on top of the define to explain it.

-- 
error compiling committee.c: too many arguments to function