qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: "lmr@redhat.com" <lmr@redhat.com>,
	"Li, Haicheng" <haicheng.li@intel.com>,
	Max Asbock <masbock@linux.vnet.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Zheng, Jiajia" <jiajia.zheng@intel.com>,
	"You, Yongkang" <yongkang.you@intel.com>,
	"Kleen, Andi" <andi.kleen@intel.com>
Subject: Re: [Qemu-devel] [Patch] Support translating Guest physical	address to Host virtual address.
Date: Sun, 07 Feb 2010 10:23:24 -0600	[thread overview]
Message-ID: <4B6EE8FC.9080602@codemonkey.ws> (raw)
In-Reply-To: <4B6EC835.3010805@redhat.com>

On 02/07/2010 08:03 AM, Avi Kivity wrote:
> On 02/03/2010 06:14 PM, Anthony Liguori wrote:
>>>> aren't we putting the cart before the horse here?
>>> qemu has support for triggering MCEs on the monitor.
>>>
>>> Also the KVM code base has support for forwarding the MCEs 
>>> automatically.
>>
>> KVM has all of the information you need (guest physical -> host 
>> physical mapping).  It can also pin the mapping making it much safer 
>> to interface at that level.  You should probably add an ioctl 
>> interface to KVM to get a host physical from a given guest physical 
>> and then use that to do the MCE injection.  You would need to write a 
>> little helper tool and you would need a way to get an fd for an 
>> existing guest.
>>
>
> It would be simpler to trigger the whole thing from within qemu.

Only insofar as you don't have to deal with getting at the VM fd.  You 
can avoid the problem by having the kvm ioctl interface take a pid or 
something.

The problem I have with driving this through qemu is that it's purely a 
test mechanism and it's not even one that we can verify within qemu.  
It's a command that isn't really useful in anything but a very specific 
context.

I don't think it's the right thing to do to add dozens of monitor 
commands to enable test harnesses that are not related to actual 
functionality within qemu.

Regards,

Anthony Liguori

  reply	other threads:[~2010-02-07 16:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  3:25 [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address Zheng, Jiajia
2010-01-27 21:39 ` Anthony Liguori
2010-01-27 22:31   ` Max Asbock
2010-02-03  4:04     ` Zheng, Jiajia
2010-02-03 13:41       ` Anthony Liguori
2010-02-03 14:11         ` Kleen, Andi
2010-02-03 14:23           ` Anthony Liguori
2010-02-03 15:29             ` Lucas Meneghel Rodrigues
2010-02-03 15:49             ` Kleen, Andi
2010-02-03 16:14               ` Anthony Liguori
2010-02-05  2:07                 ` Zheng, Jiajia
2010-02-07 14:03                 ` Avi Kivity
2010-02-07 16:23                   ` Anthony Liguori [this message]
2010-02-07 16:31                     ` Avi Kivity
2010-02-07 22:09                       ` Anthony Liguori
2010-02-08  3:38                         ` Zheng, Jiajia
2010-02-08  8:43                         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6EE8FC.9080602@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=andi.kleen@intel.com \
    --cc=avi@redhat.com \
    --cc=haicheng.li@intel.com \
    --cc=jiajia.zheng@intel.com \
    --cc=lmr@redhat.com \
    --cc=masbock@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yongkang.you@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).