From: Anthony Liguori <anthony@codemonkey.ws>
To: john cooper <john.cooper@redhat.com>
Cc: "Przywara, Andre" <Andre.Przywara@amd.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>,
Mark McLoughlin <markmc@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..
Date: Sun, 07 Feb 2010 10:24:31 -0600 [thread overview]
Message-ID: <4B6EE93F.3030406@codemonkey.ws> (raw)
In-Reply-To: <4B6DBC01.4060307@redhat.com>
On 02/06/2010 12:59 PM, john cooper wrote:
> This patch reworks support for both assignment and
> append in the config file parser. It was motivated
> by comments received on the cpu model config file
> format.
>
> Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9
> changed the behavior of "=" from assign to append.
> This patch preserves the ability to append to an
> option (however now via "+="), reverts "=" to its
> previous behavior, and allows both to interoperate.
>
> Signed-off-by: john cooper<john.cooper@redhat.com>
>
This deviates from standard ini syntax which makes me a big
uncomfortable with it. Gerd, do you have an opinion?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-02-07 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 19:02 [Qemu-devel] [PATCH] Add cpu model configuration support.. (resend) john cooper
2010-02-02 10:17 ` [Qemu-devel] " Andre Przywara
2010-02-02 11:07 ` Andre Przywara
2010-02-02 19:34 ` john cooper
2010-02-06 18:59 ` [Qemu-devel] [PATCH] Add assignment operation to config file parser john cooper
2010-02-07 16:24 ` Anthony Liguori [this message]
2010-02-08 13:21 ` Gerd Hoffmann
2010-02-08 16:00 ` john cooper
2010-06-09 8:05 ` [Qemu-devel] [PATCH] Add optional dump of default config file paths john cooper
2010-06-14 17:01 ` Anthony Liguori
2010-06-14 17:07 ` Daniel P. Berrange
2010-06-14 17:59 ` john cooper
2010-06-14 19:13 ` Anthony Liguori
2010-02-10 20:00 ` [Qemu-devel] [PATCH] Add cpu model configuration support.. (resend) Anthony Liguori
2010-02-14 6:52 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6EE93F.3030406@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Andre.Przywara@amd.com \
--cc=john.cooper@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).