From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ne9w4-0001i1-V6 for qemu-devel@nongnu.org; Sun, 07 Feb 2010 11:24:36 -0500 Received: from [199.232.76.173] (port=35159 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ne9w3-0001hm-TM for qemu-devel@nongnu.org; Sun, 07 Feb 2010 11:24:35 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ne9w2-00069H-Hu for qemu-devel@nongnu.org; Sun, 07 Feb 2010 11:24:35 -0500 Received: from mail-yx0-f183.google.com ([209.85.210.183]:63863) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ne9w2-000697-7x for qemu-devel@nongnu.org; Sun, 07 Feb 2010 11:24:34 -0500 Received: by yxe13 with SMTP id 13so3719940yxe.18 for ; Sun, 07 Feb 2010 08:24:33 -0800 (PST) Message-ID: <4B6EE93F.3030406@codemonkey.ws> Date: Sun, 07 Feb 2010 10:24:31 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser.. References: <4B672535.5050303@redhat.com> <4B6DBC01.4060307@redhat.com> In-Reply-To: <4B6DBC01.4060307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: john cooper Cc: "Przywara, Andre" , Gerd Hoffmann , qemu-devel@nongnu.org, KVM list , Mark McLoughlin On 02/06/2010 12:59 PM, john cooper wrote: > This patch reworks support for both assignment and > append in the config file parser. It was motivated > by comments received on the cpu model config file > format. > > Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9 > changed the behavior of "=" from assign to append. > This patch preserves the ability to append to an > option (however now via "+="), reverts "=" to its > previous behavior, and allows both to interoperate. > > Signed-off-by: john cooper > This deviates from standard ini syntax which makes me a big uncomfortable with it. Gerd, do you have an opinion? Regards, Anthony Liguori