From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NePBE-0006yK-2Z for qemu-devel@nongnu.org; Mon, 08 Feb 2010 03:41:16 -0500 Received: from [199.232.76.173] (port=33719 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NePBD-0006xy-80 for qemu-devel@nongnu.org; Mon, 08 Feb 2010 03:41:15 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NePB9-0001AC-F6 for qemu-devel@nongnu.org; Mon, 08 Feb 2010 03:41:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11340) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NePB9-0001A2-34 for qemu-devel@nongnu.org; Mon, 08 Feb 2010 03:41:11 -0500 Message-ID: <4B6FCE15.9030306@redhat.com> Date: Mon, 08 Feb 2010 09:40:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] How fun it must be to commit patches without posting them! List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel malc, commit bc5b600 does the same thing as the series I posted at http://permalink.gmane.org/gmane.comp.emulators.qemu/62997, only worse: 1) for vl.c and qemu-img.c, it disable FORTIFY_SOURCE checking which is only enabled by the printf macro: # define printf(...) \ __builtin___printf_chk (__USE_FORTIFY_LEVEL - 1, __VA_ARGS__) 2) for readline.c, it includes a useless complication, namely #ifdef printf #undef printf #endif 3) for vl.c, it doesn't take the occasion to cleanup qemu-options.hx's useless usage of % sequences that are filled in by vl.c. Please revert it and commit my series instead, or explain why you didn't care about reading the entire thread or about explicitly NACKing my patches. Paolo