From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NeQj1-0002oy-Mc for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:20:15 -0500 Received: from [199.232.76.173] (port=34512 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NeQj0-0002ob-Ny for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:20:15 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NeQiw-0007oD-5t for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:20:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63809) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NeQiv-0007nn-Ni for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:20:09 -0500 Message-ID: <4B6FE54E.5040403@redhat.com> Date: Mon, 08 Feb 2010 12:19:58 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20091213151408.GB22854@morn.localdomain> <4B26047A.60409@virtutech.com> <20091224002906.GB6273@morn.localdomain> <4B4C3C91.8090606@virtutech.com> <20100112133631.GA21099@morn.localdomain> In-Reply-To: <20100112133631.GA21099@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] Seabios: Fix PkgLength calculation for the SSDT. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org, Magnus Christensson On 01/12/2010 03:36 PM, Kevin O'Connor wrote: > On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote: > >> On 12/24/2009 01:29 AM, Kevin O'Connor wrote: >> >>> On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote: >>> >>>>> Should be cpu_length + 2 as far as I can tell. The current code is >>>>> definitely broken. >>>>> >>>>> >>>> Right. That should be cpu_length +2 in the else-part. >>>> >>> Can you resend the patch with the change? >>> >> Attached (sorry for the delay). >> > Thanks. Commit 3012af18. > Without this patch, Windows 2008 r2 won't boot with more than 4 cpus. Kevin/Anthony, can you coordinate a SeaBIOS release including this patch? Probably needed for qemu 0.12 as well. -- error compiling committee.c: too many arguments to function