From: Kevin Wolf <kwolf@redhat.com>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org, sheng@linux.intel.com
Subject: Re: [Qemu-devel] [PATCH v3] block: more read-only changes, related to backing files
Date: Mon, 08 Feb 2010 11:23:54 +0100 [thread overview]
Message-ID: <4B6FE63A.1070804@redhat.com> (raw)
In-Reply-To: <1265552353-31189-1-git-send-email-nsprei@redhat.com>
Am 07.02.2010 15:19, schrieb Naphtali Sprei:
> This version addresses comments by Kevin Wolf <kwolf@redhat.com> to v2
> Also separate commits squashed.
>
>
> Open image file read-only where possible
> Upgrade file to read-write during commit, back to read-only after commit
> Added option for qemu-img.c bdrv_new_open() to open file as read-only
>
> qemu-img changes based on patch by Sheng Yang <sheng@linux.intel.com>
>
>
> Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
Looks much better to me now.
The only thing I'm still unsure about is what to do with the case where
re-opening the image fails completely. Have you tested this case? I have
no idea what would happen, probably a segfault somewhere.
Kevin
prev parent reply other threads:[~2010-02-08 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 14:19 [Qemu-devel] [PATCH v3] block: more read-only changes, related to backing files Naphtali Sprei
2010-02-08 10:23 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6FE63A.1070804@redhat.com \
--to=kwolf@redhat.com \
--cc=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).