From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NeQnW-0004Aq-Ez for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:24:54 -0500 Received: from [199.232.76.173] (port=37005 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NeQnV-0004Aa-Mu for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:24:53 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NeQnQ-0000h2-8X for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:24:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40418) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NeQnP-0000gC-Rx for qemu-devel@nongnu.org; Mon, 08 Feb 2010 05:24:48 -0500 Message-ID: <4B6FE63A.1070804@redhat.com> Date: Mon, 08 Feb 2010 11:23:54 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3] block: more read-only changes, related to backing files References: <1265552353-31189-1-git-send-email-nsprei@redhat.com> In-Reply-To: <1265552353-31189-1-git-send-email-nsprei@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Naphtali Sprei Cc: qemu-devel@nongnu.org, sheng@linux.intel.com Am 07.02.2010 15:19, schrieb Naphtali Sprei: > This version addresses comments by Kevin Wolf to v2 > Also separate commits squashed. > > > Open image file read-only where possible > Upgrade file to read-write during commit, back to read-only after commit > Added option for qemu-img.c bdrv_new_open() to open file as read-only > > qemu-img changes based on patch by Sheng Yang > > > Signed-off-by: Naphtali Sprei Looks much better to me now. The only thing I'm still unsure about is what to do with the case where re-opening the image fails completely. Have you tested this case? I have no idea what would happen, probably a segfault somewhere. Kevin