From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NeRZW-0008KY-Cq
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:14:30 -0500
Received: from [199.232.76.173] (port=33485 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NeRZV-0008KB-AL
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:14:29 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1NeRZP-0007hV-QK
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:14:29 -0500
Received: from mx20.gnu.org ([199.232.41.8]:62488)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NeRZP-0007fp-Ha
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:14:23 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NeRZN-0000YQ-KP
	for qemu-devel@nongnu.org; Mon, 08 Feb 2010 06:14:21 -0500
Message-ID: <4B6FF203.6010304@redhat.com>
Date: Mon, 08 Feb 2010 12:14:11 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.
References: <20100208064147.GD22624@valinux.co.jp>
	<20100208101753.GA14662@redhat.com>
In-Reply-To: <20100208101753.GA14662@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

On 02/08/10 11:17, Michael S. Tsirkin wrote:
> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>> initialize header type register in pci generic code.
>>
>> Cc: Blue Swirl<blauwirbel@gmail.com>
>> Cc: "Michael S. Tsirkin"<mst@redhat.com>
>> Signed-off-by: Isaku Yamahata<yamahata@valinux.co.jp>
>
> No objections here, I am assuming this will be followed
> by patches removing header type init from bridges?
>  From qdev perspective, it is probably cleaner to make
> multifunction bit a separate qdev property though, right?

 From a qdev perspective it would make *alot* of sense to move a bunch 
of pci config stuff (including, but not limited to header type) into 
PCIDeviceInfo.

cheers,
   Gerd