From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging
Date: Mon, 08 Feb 2010 08:53:26 -0600 [thread overview]
Message-ID: <4B702566.30605@codemonkey.ws> (raw)
In-Reply-To: <m3d40jiozi.fsf@blackfin.pond.sub.org>
On 02/05/2010 11:14 AM, Markus Armbruster wrote:
>> Run time asserts are a terrible way to deal with reasonably expected errors.
>>
> Yes. But what's reasonably expected entirely depends on the contract
> between the function and its callers.
>
> I think we need a function that cannot fail and shouldn't used with
> untrusted arguments (for what it's worth, that's how we use
> qobject_from_jsonf() now). Having related functions with different
> contracts is fine with me.
>
I think the key point is that if we're going to establish these
contracts, it must be obvious.
A reasonable programmer is going to assume that if a function can return
a NULL, it can possibly return an error. If you want to deviate from
those semantics, you either have to name the function appropriately or
put a big comment above the declaration explaining the semantics.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-02-08 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 20:13 [Qemu-devel] [PATCH v0 0/4]: QMP related fixes Luiz Capitulino
2010-02-04 20:13 ` [Qemu-devel] [PATCH 1/4] qjson: Improve debugging Luiz Capitulino
2010-02-04 22:31 ` Anthony Liguori
2010-02-05 9:13 ` Markus Armbruster
2010-02-05 12:13 ` Luiz Capitulino
2010-02-05 12:12 ` Luiz Capitulino
2010-02-05 15:54 ` Anthony Liguori
2010-02-05 17:14 ` Markus Armbruster
2010-02-08 11:22 ` Luiz Capitulino
2010-02-08 14:53 ` Anthony Liguori [this message]
2010-02-08 15:05 ` Luiz Capitulino
2010-02-04 20:13 ` [Qemu-devel] [PATCH 2/4] Monitor: remove unneeded checks Luiz Capitulino
2010-02-04 20:13 ` [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults Luiz Capitulino
2010-02-05 9:15 ` Markus Armbruster
2010-02-05 14:21 ` Markus Armbruster
2010-02-05 14:44 ` Luiz Capitulino
2010-02-05 15:15 ` Markus Armbruster
2010-02-05 17:07 ` Luiz Capitulino
2010-02-04 20:13 ` [Qemu-devel] [PATCH 4/4] QMP: Don't leak on connection close Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 19:01 [Qemu-devel] [PATCH v1 0/4]: QMP related fixes Luiz Capitulino
2010-02-08 19:01 ` [Qemu-devel] [PATCH 1/4] qjson: Improve debugging Luiz Capitulino
2010-02-10 21:41 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B702566.30605@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).