From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NeXCa-0003CD-Gw for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:15:12 -0500 Received: from [199.232.76.173] (port=37703 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NeXCa-0003C5-4e for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:15:12 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NeXCY-0003fI-Ms for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:15:11 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:54380) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NeXCY-0003f2-Cr for qemu-devel@nongnu.org; Mon, 08 Feb 2010 12:15:10 -0500 Received: by fg-out-1718.google.com with SMTP id 16so190992fgg.10 for ; Mon, 08 Feb 2010 09:15:09 -0800 (PST) Message-ID: <4B704697.8080500@codemonkey.ws> Date: Mon, 08 Feb 2010 11:15:03 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [SeaBIOS] [PATCH] Seabios: Fix PkgLength calculation for the SSDT. References: <20091213151408.GB22854@morn.localdomain> <4B26047A.60409@virtutech.com> <20091224002906.GB6273@morn.localdomain> <4B4C3C91.8090606@virtutech.com> <20100112133631.GA21099@morn.localdomain> <4B6FE54E.5040403@redhat.com> In-Reply-To: <4B6FE54E.5040403@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kevin O'Connor , seabios@seabios.org, qemu-devel@nongnu.org, Magnus Christensson On 02/08/2010 04:19 AM, Avi Kivity wrote: > On 01/12/2010 03:36 PM, Kevin O'Connor wrote: >> On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote: >>> On 12/24/2009 01:29 AM, Kevin O'Connor wrote: >>>> On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote: >>>>>> Should be cpu_length + 2 as far as I can tell. The current code is >>>>>> definitely broken. >>>>>> >>>>> Right. That should be cpu_length +2 in the else-part. >>>> Can you resend the patch with the change? >>> Attached (sorry for the delay). >> Thanks. Commit 3012af18. > > Without this patch, Windows 2008 r2 won't boot with more than 4 cpus. > Kevin/Anthony, can you coordinate a SeaBIOS release including this patch? > > Probably needed for qemu 0.12 as well. Kevin, Just let me know when you cut a new release. Did we ever decide what to do about a stable branch? Regards, Anthony Liguori