From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfCUc-0005nV-PA for qemu-devel@nongnu.org; Wed, 10 Feb 2010 08:20:34 -0500 Received: from [199.232.76.173] (port=50109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfCUb-0005nN-Fw for qemu-devel@nongnu.org; Wed, 10 Feb 2010 08:20:33 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfCUa-0002Jz-3C for qemu-devel@nongnu.org; Wed, 10 Feb 2010 08:20:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42754) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfCUZ-0002Jp-Ne for qemu-devel@nongnu.org; Wed, 10 Feb 2010 08:20:31 -0500 Message-ID: <4B72B28E.6010801@redhat.com> Date: Wed, 10 Feb 2010 15:20:14 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4B728FF9.6010707@lab.ntt.co.jp> In-Reply-To: <4B728FF9.6010707@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: OHMURA Kei Cc: Anthony Liguori , mtosatti@redhat.com, "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On 02/10/2010 12:52 PM, OHMURA Kei wrote: > dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. > But We think that dirty-bitmap-traveling by long size is faster than by byte > size especially when most of memory is not dirty. > > --- a/bswap.h > +++ b/bswap.h > @@ -209,7 +209,6 @@ static inline void cpu_to_be32wu(uint32_t *p, uint32_t v) > #define cpu_to_32wu cpu_to_le32wu > #endif > > -#undef le_bswap > #undef be_bswap > #undef le_bswaps > Anthony, is it okay to export le_bswap this way, or will you want leul_to_cpu()? -- error compiling committee.c: too many arguments to function