From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfFf1-0002Uo-AJ for qemu-devel@nongnu.org; Wed, 10 Feb 2010 11:43:31 -0500 Received: from [199.232.76.173] (port=54352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfFf0-0002UP-PK for qemu-devel@nongnu.org; Wed, 10 Feb 2010 11:43:30 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfFey-0002KA-Ix for qemu-devel@nongnu.org; Wed, 10 Feb 2010 11:43:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18015) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfFev-0002J2-5m for qemu-devel@nongnu.org; Wed, 10 Feb 2010 11:43:26 -0500 Message-ID: <4B72E226.9010100@redhat.com> Date: Wed, 10 Feb 2010 18:43:18 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling References: <4B728FF9.6010707@lab.ntt.co.jp> <4B72B28E.6010801@redhat.com> <4B72D69D.7050005@codemonkey.ws> <4B72D838.9060603@suse.de> <4B72E051.8090008@codemonkey.ws> In-Reply-To: <4B72E051.8090008@codemonkey.ws> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , mtosatti@redhat.com, OHMURA Kei , Alexander Graf On 02/10/2010 06:35 PM, Anthony Liguori wrote: > On 02/10/2010 10:00 AM, Alexander Graf wrote: > >> On PPC the bitmap is Little Endian. >> >> > Out of curiousity, why? It seems like an odd interface. > > Exactly this issue. If you specify it as unsigned long native endian, there is ambiguity between 32-bit and 64-bit userspace. If you specify it as uint64_t native endian, you have an inefficient implementation on 32-bit userspace. So we went for unsigned byte native endian, which is the same as any size little endian. (well I think the real reason is that it just grew that way out of x86, but the above is quite plausible). -- error compiling committee.c: too many arguments to function