From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling
Date: Wed, 10 Feb 2010 12:32:47 -0600 [thread overview]
Message-ID: <4B72FBCF.3000708@codemonkey.ws> (raw)
In-Reply-To: <1265208064-16039-2-git-send-email-lcapitulino@redhat.com>
On 02/03/2010 08:41 AM, Luiz Capitulino wrote:
> This commit adds the basic definitions for the BLOCK_IO_ERROR
> event, but actual event emission will be introduced by the
> next commits.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>
Applied all. Thanks.
Regards,
Anthony Liguori
> ---
> QMP/qmp-events.txt | 21 +++++++++++++++++++++
> monitor.c | 3 +++
> monitor.h | 1 +
> 3 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index dc48ccc..d585a8d 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt
> @@ -43,3 +43,24 @@ Data: 'server' and 'client' keys with the same keys as 'query-vnc'.
>
> Description: Issued when the VNC session is made active.
> Data: 'server' and 'client' keys with the same keys as 'query-vnc'.
> +
> +7 BLOCK_IO_ERROR
> +----------------
> +
> +Description: Issued when a disk I/O error occurs
> +Data:
> +
> +- 'device': device name (json-string)
> +- 'operation': I/O operation (json-string, "read" or "write")
> +- 'action': action that has been taken, it's one of the following:
> + "ignore": error has been ignored
> + "report": error has been reported to the device
> + "stop": error caused VM to be stopped
> +
> +Example:
> +
> +{ "event": "BLOCK_IO_ERROR",
> + "data": { "device": "ide0-hd1",
> + "operation": "write",
> + "action": "stop" },
> + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> diff --git a/monitor.c b/monitor.c
> index fb7c572..6e688ac 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -378,6 +378,9 @@ void monitor_protocol_event(MonitorEvent event, QObject *data)
> case QEVENT_VNC_DISCONNECTED:
> event_name = "VNC_DISCONNECTED";
> break;
> + case QEVENT_BLOCK_IO_ERROR:
> + event_name = "BLOCK_IO_ERROR";
> + break;
> default:
> abort();
> break;
> diff --git a/monitor.h b/monitor.h
> index b0f9270..e35f1e4 100644
> --- a/monitor.h
> +++ b/monitor.h
> @@ -23,6 +23,7 @@ typedef enum MonitorEvent {
> QEVENT_VNC_CONNECTED,
> QEVENT_VNC_INITIALIZED,
> QEVENT_VNC_DISCONNECTED,
> + QEVENT_BLOCK_IO_ERROR,
> QEVENT_MAX,
> } MonitorEvent;
>
>
next prev parent reply other threads:[~2010-02-10 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 14:40 [Qemu-devel] [PATCH v1 0/5]: BLOCK_IO_ERROR QMP event Luiz Capitulino
2010-02-03 14:41 ` [Qemu-devel] [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling Luiz Capitulino
2010-02-10 18:32 ` Anthony Liguori [this message]
2010-02-03 14:41 ` [Qemu-devel] [PATCH 2/5] block: BLOCK_IO_ERROR QMP event Luiz Capitulino
2010-02-03 14:41 ` [Qemu-devel] [PATCH 3/5] ide: Generate " Luiz Capitulino
2010-02-03 14:41 ` [Qemu-devel] [PATCH 4/5] scsi: " Luiz Capitulino
2010-02-03 14:41 ` [Qemu-devel] [PATCH 5/5] virtio-blk: " Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2010-02-02 21:10 [Qemu-devel] [PATCH v0 0/5]: " Luiz Capitulino
2010-02-02 21:10 ` [Qemu-devel] [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B72FBCF.3000708@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).