From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfHMq-0005a0-V0 for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:32:52 -0500 Received: from [199.232.76.173] (port=49517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfHMq-0005Zs-3M for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:32:52 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfHMo-0001Fu-KN for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:32:51 -0500 Received: from mail-iw0-f194.google.com ([209.85.223.194]:46951) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfHMo-000178-C5 for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:32:50 -0500 Received: by mail-iw0-f194.google.com with SMTP id 32so527339iwn.14 for ; Wed, 10 Feb 2010 10:32:50 -0800 (PST) Message-ID: <4B72FBCF.3000708@codemonkey.ws> Date: Wed, 10 Feb 2010 12:32:47 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling References: <1265208064-16039-1-git-send-email-lcapitulino@redhat.com> <1265208064-16039-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1265208064-16039-2-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org On 02/03/2010 08:41 AM, Luiz Capitulino wrote: > This commit adds the basic definitions for the BLOCK_IO_ERROR > event, but actual event emission will be introduced by the > next commits. > > Signed-off-by: Luiz Capitulino > Applied all. Thanks. Regards, Anthony Liguori > --- > QMP/qmp-events.txt | 21 +++++++++++++++++++++ > monitor.c | 3 +++ > monitor.h | 1 + > 3 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > index dc48ccc..d585a8d 100644 > --- a/QMP/qmp-events.txt > +++ b/QMP/qmp-events.txt > @@ -43,3 +43,24 @@ Data: 'server' and 'client' keys with the same keys as 'query-vnc'. > > Description: Issued when the VNC session is made active. > Data: 'server' and 'client' keys with the same keys as 'query-vnc'. > + > +7 BLOCK_IO_ERROR > +---------------- > + > +Description: Issued when a disk I/O error occurs > +Data: > + > +- 'device': device name (json-string) > +- 'operation': I/O operation (json-string, "read" or "write") > +- 'action': action that has been taken, it's one of the following: > + "ignore": error has been ignored > + "report": error has been reported to the device > + "stop": error caused VM to be stopped > + > +Example: > + > +{ "event": "BLOCK_IO_ERROR", > + "data": { "device": "ide0-hd1", > + "operation": "write", > + "action": "stop" }, > + "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > diff --git a/monitor.c b/monitor.c > index fb7c572..6e688ac 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -378,6 +378,9 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) > case QEVENT_VNC_DISCONNECTED: > event_name = "VNC_DISCONNECTED"; > break; > + case QEVENT_BLOCK_IO_ERROR: > + event_name = "BLOCK_IO_ERROR"; > + break; > default: > abort(); > break; > diff --git a/monitor.h b/monitor.h > index b0f9270..e35f1e4 100644 > --- a/monitor.h > +++ b/monitor.h > @@ -23,6 +23,7 @@ typedef enum MonitorEvent { > QEVENT_VNC_CONNECTED, > QEVENT_VNC_INITIALIZED, > QEVENT_VNC_DISCONNECTED, > + QEVENT_BLOCK_IO_ERROR, > QEVENT_MAX, > } MonitorEvent; > >