From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NfHZe-0001Bl-PS
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:46:06 -0500
Received: from [199.232.76.173] (port=44620 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NfHZe-0001BN-8w
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:46:06 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NfHZb-0002T7-0U
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:46:06 -0500
Received: from mail-yw0-f179.google.com ([209.85.211.179]:42286)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NfHZa-0002T3-P5
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 13:46:02 -0500
Received: by ywh9 with SMTP id 9so319537ywh.19
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2010 10:46:02 -0800 (PST)
Message-ID: <4B72FEE7.4070009@codemonkey.ws>
Date: Wed, 10 Feb 2010 12:45:59 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] add close callback for tty-based char device
References: <4B69A1C7.80708@cisco.com>
In-Reply-To: <4B69A1C7.80708@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "David S. Ahern" <daahern@cisco.com>
Cc: qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>

On 02/03/2010 10:18 AM, David S. Ahern wrote:
> Add a tty close callback. Right now if a guest device that is connected
> to a tty-based chardev in the host is removed, the tty is not closed.
> With this patch it is closed.
>
> Example use case is connecting an emulated USB serial cable in the guest
> to tty0 of the host using the monitor command:
>
> usb_add serial::/dev/tty0
>
> and then removing the device with:
>
> usb_del serial::/dev/tty0
>
> Signed-off-by: David Ahern<daahern@cisco.com>
>    

This patch is whitespace damaged.

> diff --git a/qemu-char.c b/qemu-char.c
> index 800ee6c..ecd84ec 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1173,6 +1173,20 @@ static int tty_serial_ioctl(CharDriverState *chr,
> int cmd
>    

Right here and in other places.

Regards,

Anthony Liguori

>       return 0;
>   }
>
> +static void qemu_chr_close_tty(CharDriverState *chr)
> +{
> +    FDCharDriver *s = chr->opaque;
> +    int fd = -1;
> +
> +    if (s)
> +        fd = s->fd_in;
> +
> +    fd_chr_close(chr);
> +
> +    if (fd>= 0)
> +        close(fd);
> +}
> +
>   static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>   {
>       const char *filename = qemu_opt_get(opts, "path");
> @@ -1187,6 +1201,7 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts
> *opts)
>           return NULL;
>       }
>       chr->chr_ioctl = tty_serial_ioctl;
> +    chr->chr_close = qemu_chr_close_tty;
>       return chr;
>   }
>   #else  /* ! __linux__&&  ! __sun__ */
>
>
>
>
>