From: Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] iothread: fix vcpu stop with smp tcg
Date: Wed, 10 Feb 2010 13:31:43 -0600 [thread overview]
Message-ID: <4B73099F.9030505@codemonkey.ws> (raw)
In-Reply-To: <20100209144904.GA31343@amt.cnet>
On 02/09/2010 08:49 AM, Marcelo Tosatti wrote:
> Round robin vcpus in tcg_cpu_next even if the vm stopped. This
> allows all cpus to enter stopped state.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> diff --git a/vl.c b/vl.c
> index 880bcd5..f61e362 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3855,14 +3855,15 @@ static void tcg_cpu_exec(void)
> for (; next_cpu != NULL; next_cpu = next_cpu->next_cpu) {
> CPUState *env = cur_cpu = next_cpu;
>
> - if (!vm_running)
> - break;
> if (timer_alarm_pending) {
> timer_alarm_pending = 0;
> break;
> }
> if (cpu_can_run(env))
> ret = qemu_cpu_exec(env);
> + else if (env->stop)
> + break;
> +
> if (ret == EXCP_DEBUG) {
> gdb_set_stop_cpu(env);
> debug_requested = 1;
>
>
>
>
prev parent reply other threads:[~2010-02-10 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 13:40 [Qemu-devel] iothread + smp 2 + alt-f4 = lock-up Jan Kiszka
2010-02-09 14:49 ` [Qemu-devel] [PATCH] iothread: fix vcpu stop with smp tcg Marcelo Tosatti
2010-02-10 19:31 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B73099F.9030505@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).