From: Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: xming <xmingske@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix inet_parse typo
Date: Wed, 10 Feb 2010 13:31:52 -0600 [thread overview]
Message-ID: <4B7309A8.1000602@codemonkey.ws> (raw)
In-Reply-To: <20100209173146.GA1881@amt.cnet>
On 02/09/2010 11:31 AM, Marcelo Tosatti wrote:
> qemu_opt_set wants on/off, not yes/no.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index 8850516..a88b2a7 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
> __FUNCTION__, str);
> return -1;
> }
> - qemu_opt_set(opts, "ipv6", "yes");
> + qemu_opt_set(opts, "ipv6", "on");
> } else if (qemu_isdigit(str[0])) {
> /* IPv4 addr */
> if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
> @@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
> __FUNCTION__, str);
> return -1;
> }
> - qemu_opt_set(opts, "ipv4", "yes");
> + qemu_opt_set(opts, "ipv4", "on");
> } else {
> /* hostname */
> if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
> @@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
> if (h)
> qemu_opt_set(opts, "to", h+4);
> if (strstr(optstr, ",ipv4"))
> - qemu_opt_set(opts, "ipv4", "yes");
> + qemu_opt_set(opts, "ipv4", "on");
> if (strstr(optstr, ",ipv6"))
> - qemu_opt_set(opts, "ipv6", "yes");
> + qemu_opt_set(opts, "ipv6", "on");
> return 0;
> }
>
>
>
>
>
prev parent reply other threads:[~2010-02-10 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 17:31 [Qemu-devel] [PATCH] fix inet_parse typo Marcelo Tosatti
2010-02-10 19:31 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7309A8.1000602@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xmingske@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).