From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NfII0-0002fg-Uu
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:31:56 -0500
Received: from [199.232.76.173] (port=58600 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NfII0-0002fW-Kr
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:31:56 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NfIHz-0005z8-E2
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:31:56 -0500
Received: from mail-iw0-f194.google.com ([209.85.223.194]:39936)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NfIHz-0005xc-4M
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:31:55 -0500
Received: by mail-iw0-f194.google.com with SMTP id 32so643729iwn.14
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2010 11:31:54 -0800 (PST)
Message-ID: <4B7309A8.1000602@codemonkey.ws>
Date: Wed, 10 Feb 2010 13:31:52 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix inet_parse typo
References: <20100209173146.GA1881@amt.cnet>
In-Reply-To: <20100209173146.GA1881@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: xming <xmingske@gmail.com>, qemu-devel@nongnu.org

On 02/09/2010 11:31 AM, Marcelo Tosatti wrote:
> qemu_opt_set wants on/off, not yes/no.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index 8850516..a88b2a7 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
>                       __FUNCTION__, str);
>               return -1;
>           }
> -        qemu_opt_set(opts, "ipv6", "yes");
> +        qemu_opt_set(opts, "ipv6", "on");
>       } else if (qemu_isdigit(str[0])) {
>           /* IPv4 addr */
>           if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
> @@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
>                       __FUNCTION__, str);
>               return -1;
>           }
> -        qemu_opt_set(opts, "ipv4", "yes");
> +        qemu_opt_set(opts, "ipv4", "on");
>       } else {
>           /* hostname */
>           if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
> @@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
>       if (h)
>           qemu_opt_set(opts, "to", h+4);
>       if (strstr(optstr, ",ipv4"))
> -        qemu_opt_set(opts, "ipv4", "yes");
> +        qemu_opt_set(opts, "ipv4", "on");
>       if (strstr(optstr, ",ipv6"))
> -        qemu_opt_set(opts, "ipv6", "yes");
> +        qemu_opt_set(opts, "ipv6", "on");
>       return 0;
>   }
>
>
>
>
>