From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NfITY-00071F-Hf
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:43:52 -0500
Received: from [199.232.76.173] (port=35234 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NfITX-00070u-Vn
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:43:52 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NfITW-0002Nx-H7
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:43:51 -0500
Received: from mail-iw0-f194.google.com ([209.85.223.194]:48869)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NfITW-0002J0-9W
	for qemu-devel@nongnu.org; Wed, 10 Feb 2010 14:43:50 -0500
Received: by mail-iw0-f194.google.com with SMTP id 32so667084iwn.14
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2010 11:43:50 -0800 (PST)
Message-ID: <4B730C73.7000702@codemonkey.ws>
Date: Wed, 10 Feb 2010 13:43:47 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] versatile_pci: cleanup
References: <cover.1265665089.git.mst@redhat.com>
	<20100208214308.GC28285@redhat.com>
In-Reply-To: <20100208214308.GC28285@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/08/2010 03:43 PM, Michael S. Tsirkin wrote:
> Cleanup versatile_pci: no need to re-set fields
> to zero (pci core sets 0 already), use set_word
> for status field. Compile-tested only, but seems obvious.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>    

Acked-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori
> ---
>   hw/versatile_pci.c |   11 ++---------
>   1 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
> index e58b7f4..7f79348 100644
> --- a/hw/versatile_pci.c
> +++ b/hw/versatile_pci.c
> @@ -147,15 +147,8 @@ static int versatile_pci_host_init(PCIDevice *d)
>       pci_config_set_vendor_id(d->config, PCI_VENDOR_ID_XILINX);
>       /* Both boards have the same device ID.  Oh well.  */
>       pci_config_set_device_id(d->config, PCI_DEVICE_ID_XILINX_XC2VP30);
> -    /* TODO: no need to clear command */
> -    pci_set_byte(d->config + PCI_COMMAND, 0x00);
> -    pci_set_byte(d->config + PCI_COMMAND + 1, 0x00);
> -    /* TODO: convert to set_word */
> -    pci_set_byte(d->config + PCI_STATUS, PCI_STATUS_66MHZ);
> -    pci_set_byte(d->config + PCI_STATUS + 1, PCI_STATUS_DEVSEL_MEDIUM>>  8);
> -    /* TODO: no need to clear revision/prog ifc */
> -    pci_set_byte(d->config + PCI_REVISION_ID, 0x00);
> -    pci_set_byte(d->config + PCI_CLASS_PROG, 0x00);
> +    pci_set_word(d->config + PCI_STATUS,
> +		 PCI_STATUS_66MHZ | PCI_STATUS_DEVSEL_MEDIUM);
>       pci_config_set_class(d->config, PCI_CLASS_PROCESSOR_CO);
>       pci_set_byte(d->config + PCI_LATENCY_TIMER, 0x10);
>       return 0;
>