From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NfsHH-0001w2-7l for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:57:35 -0500 Received: from [199.232.76.173] (port=51194 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NfsHG-0001va-Mn for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:57:34 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NfsHE-0006yj-HE for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:57:34 -0500 Received: from moutng.kundenserver.de ([212.227.17.10]:51642) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NfsHD-0006rA-UM for qemu-devel@nongnu.org; Fri, 12 Feb 2010 04:57:32 -0500 Message-ID: <4B752602.9020407@mail.berlios.de> Date: Fri, 12 Feb 2010 10:57:22 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1264194294-28593-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1264194294-28593-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] arm host: Fix linker warning (m68k targets) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Stefan Weil schrieb: > Compilation of m68k-softmmu or m68k-linux-user on arm host > (or cross compilation for arm) results in a linker warning: > > LINK m68k-softmmu/qemu-system-m68k > m68k-dis.o: warning: definition of `floatformat_ieee_single_little' > overriding common > arm-dis.o: warning: common is here > /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: > Warning: size of symbol `floatformat_ieee_single_little' changed from > 4 in arm-dis.o to 48 in m68k-dis.o > > floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c, > and both declarations don't match, so this is an error. > > The symbol is not needed in arm-dis.c, so I removed it there. > > Signed-off-by: Stefan Weil > --- > arm-dis.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arm-dis.c b/arm-dis.c > index 2c67d8f..4fb899e 100644 > --- a/arm-dis.c > +++ b/arm-dis.c > @@ -60,10 +60,8 @@ > #define FPU_VFP_EXT_V3 0 > #define FPU_NEON_EXT_V1 0 > > -int floatformat_ieee_single_little; > /* Assume host uses ieee float. */ > -static void floatformat_to_double (int *ignored, unsigned char *data, > - double *dest) > +static void floatformat_to_double (unsigned char *data, double *dest) > { > union { > uint32_t i; > @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, > long given, bfd_boolean thumb) > valbytes[2] = (value >> 16) & 0xff; > valbytes[3] = (value >> 24) & 0xff; > > - floatformat_to_double > - (&floatformat_ieee_single_little, valbytes, > - &fvalue); > + floatformat_to_double (valbytes, &fvalue); > > func (stream, "#%.7g\t; 0x%.8lx", fvalue, > value); The patch is still missing in git. Maybe it got lost? A linker warning about symbols which change from 4 to 48 byte should be regarded as error. Regards, Stefan Weil