From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ng25g-00084W-El
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:26:16 -0500
Received: from [199.232.76.173] (port=38318 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ng25f-00084E-VR
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:26:15 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <rth@twiddle.net>) id 1Ng25b-0000BL-9a
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:26:15 -0500
Received: from are.twiddle.net ([75.149.56.221]:48740)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1Ng25N-0000AH-NR
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:26:11 -0500
Message-ID: <4B75B934.9010204@twiddle.net>
Date: Fri, 12 Feb 2010 12:25:24 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to
	target-*/cpu.h.
References: <cover.1265933756.git.rth@twiddle.net>
	<4375b210e2ec2400c7bd1294d85d1099bcc1385d.1265933757.git.rth@twiddle.net>
	<f43fc5581002121201o59b57c67ia9150176b68491e1@mail.gmail.com>
In-Reply-To: <f43fc5581002121201o59b57c67ia9150176b68491e1@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 02/12/2010 12:01 PM, Blue Swirl wrote:
>> +#ifdef TARGET_ABI32
>> +# define TARGET_VIRT_ADDR_SPACE_BITS 32
>> +#else
>> +# define TARGET_VIRT_ADDR_SPACE_BITS 64
>> +#endif
>
> I'd suppose this change applies to all targets with ABI32, not just PPC.

Indeed.  Odd that sparc32plus didn't yield errors building, while ppc 
did -- that's how I noticed the funny config macro in the first place.

>> +#define TARGET_PHYS_ADDR_SPACE_BITS 32
>
> No. Please use the original value.

Oops.  Thanks for the catch.


r~