From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ng2TU-0003xj-Fh
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:50:52 -0500
Received: from [199.232.76.173] (port=40715 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ng2TT-0003xK-UM
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:50:52 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Ng2TS-0001nS-3r
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:50:51 -0500
Received: from mail-yx0-f182.google.com ([209.85.210.182]:59992)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Ng2TR-0001nG-PJ
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:50:49 -0500
Received: by yxe12 with SMTP id 12so1754700yxe.28
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2010 12:50:48 -0800 (PST)
Message-ID: <4B75BF24.2030604@codemonkey.ws>
Date: Fri, 12 Feb 2010 14:50:44 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1266005679.3474.5.camel@aglitke>
In-Reply-To: <1266005679.3474.5.camel@aglitke>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Fix hanging user monitor when using
	balloon command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: qemu-devel@nongnu.org

On 02/12/2010 02:14 PM, Adam Litke wrote:
> Hi Anthony.  I wonder if there was a problem when importing my async
> command handler patchset.  Since the 'balloon' command completes
> immediately, it must call the completion callback before returning.
> That call was missing but is added by the patch below.
>    

Needs a Signed-off-by.  I don't recall any fuzz with your patch but that 
was a few hundred patches ago :-)

Regards,

Anthony Liguori

> diff --git a/monitor.c b/monitor.c
> index ae125b8..f94794d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
>           return -1;
>       }
>
> +    cb(opaque, NULL);
>       return 0;
>   }
>
>