From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ngwro-0000JV-2x
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 04:03:44 -0500
Received: from [199.232.76.173] (port=55547 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ngwrn-0000JE-6p
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 04:03:43 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <kraxel@redhat.com>) id 1Ngwrl-0001XF-VX
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 04:03:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32661)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1Ngwrl-0001XB-Jk
	for qemu-devel@nongnu.org; Mon, 15 Feb 2010 04:03:41 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1F93dng023937
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 15 Feb 2010 04:03:40 -0500
Message-ID: <4B790DE6.7080109@redhat.com>
Date: Mon, 15 Feb 2010 10:03:34 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <20100212134214.GA4214@redhat.com>
	<20100212142349.GB25859@amit-x200.redhat.com>
In-Reply-To: <20100212142349.GB25859@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1
	port dev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On 02/12/10 15:23, Amit Shah wrote:
> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
>> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
>> serial devices declare MULTIPORT feature.
>> To allow 0.12 compatibility, we should clear this when
>> max_nr_ports is 1.
>
> In addition to this, setting max_nr_ports to 1 is needed when -M 0.12 is
> selected.

Indeed.

> However, is this the only way to do it? Gerd?

Is there a qdev property for max_nr_ports?  Then simply adding a compat 
property will do the trick.

cheers,
   Gerd