From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh24I-0005vt-1w for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:36:58 -0500 Received: from [199.232.76.173] (port=47607 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh24H-0005vl-LQ for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:36:57 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nh24F-0005DZ-3v for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:36:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46410) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nh24E-0005DR-Mj for qemu-devel@nongnu.org; Mon, 15 Feb 2010 09:36:54 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1FEao1c030769 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Feb 2010 09:36:53 -0500 Message-ID: <4B795BF2.2000107@redhat.com> Date: Mon, 15 Feb 2010 15:36:34 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1266240696-17880-1-git-send-email-amit.shah@redhat.com> <1266240696-17880-2-git-send-email-amit.shah@redhat.com> In-Reply-To: <1266240696-17880-2-git-send-email-amit.shah@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/3] pc: Add backward compatibility options for virtio-serial List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org > @@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = { > static void pc_machine_init(void) > { > qemu_register_machine(&pc_machine); > + qemu_register_machine(&pc_machine_v0_12); > qemu_register_machine(&pc_machine_v0_11); > qemu_register_machine(&pc_machine_v0_10); > qemu_register_machine(&isapc_machine); This chunk should have been in patch 1/3. Otherwise the whole series looks fine to me. cheers, Gerd