From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhP2F-0001YS-SN for qemu-devel@nongnu.org; Tue, 16 Feb 2010 10:08:23 -0500 Received: from [199.232.76.173] (port=40866 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhP2E-0001YF-Sl for qemu-devel@nongnu.org; Tue, 16 Feb 2010 10:08:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NhP2D-0007gh-R9 for qemu-devel@nongnu.org; Tue, 16 Feb 2010 10:08:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26615) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NhP2D-0007fr-Bl for qemu-devel@nongnu.org; Tue, 16 Feb 2010 10:08:21 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1GF8DLT016167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 16 Feb 2010 10:08:14 -0500 Message-ID: <4B7AB4D7.8030108@redhat.com> Date: Tue, 16 Feb 2010 16:08:07 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qdev: Free opts on failed do_device_add References: <1266322358-7075-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1266322358-7075-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 02/16/10 13:12, Kevin Wolf wrote: > If the device can't be created, don't leak the QemuOpts and release the id of > the device that should have been added by the failed device_add. Acked-by: Gerd Hoffmann cheers, Gerd