From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NhpMm-0007yz-7Z for qemu-devel@nongnu.org; Wed, 17 Feb 2010 14:15:20 -0500 Received: from [199.232.76.173] (port=33977 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NhpMl-0007yX-Uc for qemu-devel@nongnu.org; Wed, 17 Feb 2010 14:15:19 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NhpMl-0006bW-8X for qemu-devel@nongnu.org; Wed, 17 Feb 2010 14:15:19 -0500 Received: from are.twiddle.net ([75.149.56.221]:46261) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NhpMk-0006bQ-V5 for qemu-devel@nongnu.org; Wed, 17 Feb 2010 14:15:19 -0500 Message-ID: <4B7C4045.2000006@twiddle.net> Date: Wed, 17 Feb 2010 11:15:17 -0800 From: Richard Henderson MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/6] tcg: Optional target implementation of ANDC. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 02/17/2010 10:34 AM, Blue Swirl wrote: > On Wed, Feb 17, 2010 at 12:10 AM, Richard Henderson wrote: >> Previously ANDC was always implemented by tcg-op.h with >> an explicit NOT opcode. Allow a target implementation. > > I think the convention is to add commented out #defines or #undefs for > all targets, like sparc in bswap case: > //#define TCG_TARGET_HAS_bswap32_i32 > //#define TCG_TARGET_HAS_bswap64_i64 > or mips: > #undef TCG_TARGET_HAS_bswap32_i32 > #undef TCG_TARGET_HAS_bswap16_i32 Apparently that was only done for bswap, because there's a lot of optional opcodes that are missing everywhere. I suppose I could add those as a separate patch. r~