From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NiAtc-0002eH-UJ
	for qemu-devel@nongnu.org; Thu, 18 Feb 2010 13:14:40 -0500
Received: from [199.232.76.173] (port=34454 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NiAtc-0002dW-BB
	for qemu-devel@nongnu.org; Thu, 18 Feb 2010 13:14:40 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <daahern@cisco.com>) id 1NiAtb-00021i-Bl
	for qemu-devel@nongnu.org; Thu, 18 Feb 2010 13:14:40 -0500
Received: from rtp-iport-2.cisco.com ([64.102.122.149]:32368)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <daahern@cisco.com>) id 1NiAtb-00021I-23
	for qemu-devel@nongnu.org; Thu, 18 Feb 2010 13:14:39 -0500
Message-ID: <4B7D8388.6030207@cisco.com>
Date: Thu, 18 Feb 2010 11:14:32 -0700
From: "David S. Ahern" <daahern@cisco.com>
MIME-Version: 1.0
References: <1265851637-13035-1-git-send-email-daahern@cisco.com>
In-Reply-To: <1265851637-13035-1-git-send-email-daahern@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] add close callback for tty-based char
	device
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>

I have not seen a follow up. I believe the comments regarding whitespace
and coding style have been addressed.

Thanks,
David Ahern


On 02/10/2010 06:27 PM, David Ahern wrote:
> v1 -> v2  coding style changes
> 
> Add a tty close callback. Right now if a guest device that is connected
> to a tty-based chardev in the host is removed, the tty is not closed.
> With this patch it is closed.
> 
> Example use case is connecting an emulated USB serial cable in the guest
> to ttyS0 of the host using the monitor command:
> 
> usb_add serial::/dev/ttyS0
> 
> and then removing the device with:
> 
> usb_del serial::/dev/ttyS0
> 
> Signed-off-by: David Ahern <daahern@cisco.com>
> ---
>  qemu-char.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 75dbf66..4169492 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1173,6 +1173,22 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
>      return 0;
>  }
>  
> +static void qemu_chr_close_tty(CharDriverState *chr)
> +{
> +    FDCharDriver *s = chr->opaque;
> +    int fd = -1;
> +
> +    if (s) {
> +        fd = s->fd_in;
> +    }
> +
> +    fd_chr_close(chr);
> +
> +    if (fd >= 0) {
> +        close(fd);
> +    }
> +}
> +
>  static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>  {
>      const char *filename = qemu_opt_get(opts, "path");
> @@ -1190,6 +1206,7 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>          return NULL;
>      }
>      chr->chr_ioctl = tty_serial_ioctl;
> +    chr->chr_close = qemu_chr_close_tty;
>      return chr;
>  }
>  #else  /* ! __linux__ && ! __sun__ */