From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NiV9y-0004hM-SC
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 10:52:54 -0500
Received: from [199.232.76.173] (port=46991 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NiV9y-0004hA-9v
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 10:52:54 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <rth@twiddle.net>) id 1NiV9x-000196-LV
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 10:52:54 -0500
Received: from are.twiddle.net ([75.149.56.221]:57856)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NiV9x-00018s-BE
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 10:52:53 -0500
Message-ID: <4B7EB3D3.70507@twiddle.net>
Date: Fri, 19 Feb 2010 07:52:51 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Added Cortex_a8_v3 version, and added a
	shift instruction for NEON.
References: <4B7DD393.7070809@astc-design.com>
In-Reply-To: <4B7DD393.7070809@astc-design.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: George Karavaev <george.karavaev@astc-design.com>
Cc: qemu-devel@nongnu.org

On 02/18/2010 03:56 PM, George Karavaev wrote:
> +                            tmp64 = tcg_temp_new_i64();
> +                            tcg_gen_movi_i64(tmp64, 0);
> +                            tcg_gen_not_i64(tmp64, tmp64);

movi -1?

> +                            gen_helper_neon_shl_u64(tmp64, tmp64, cpu_V1);
> +                            tcg_gen_and_i64(cpu_V0, cpu_V0, tmp64); /*
> XXX */

Why the XXX?

> +                            tcg_gen_not_i64(tmp64, tmp64);
> +                            tcg_gen_and_i64(cpu_V1, cpu_V1, tmp64);

tcg_gen_andc_i64.


r~