From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiZwB-0007g2-CI for qemu-devel@nongnu.org; Fri, 19 Feb 2010 15:58:59 -0500 Received: from [199.232.76.173] (port=60764 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiZwA-0007fu-QK for qemu-devel@nongnu.org; Fri, 19 Feb 2010 15:58:58 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiZw7-00044z-HV for qemu-devel@nongnu.org; Fri, 19 Feb 2010 15:58:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15482) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiZw7-0003bk-4S for qemu-devel@nongnu.org; Fri, 19 Feb 2010 15:58:55 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1JKtdGV012507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Feb 2010 15:55:39 -0500 Message-ID: <4B7EFAC9.8010104@redhat.com> Date: Fri, 19 Feb 2010 14:55:37 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit() References: <1265895902-15664-1-git-send-email-armbru@redhat.com> <1265895902-15664-2-git-send-email-armbru@redhat.com> In-Reply-To: <1265895902-15664-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Mark McLoughlin , qemu-devel@nongnu.org On 02/11/2010 07:44 AM, Markus Armbruster wrote: > Unused since commit 9ad4531e. > > Signed-off-by: Markus Armbruster > Applied all. Thanks. Regards, Anthony Liguori > --- > net.c | 14 -------------- > net.h | 1 - > 2 files changed, 0 insertions(+), 15 deletions(-) > > diff --git a/net.c b/net.c > index 8e951ca..f51d376 100644 > --- a/net.c > +++ b/net.c > @@ -1128,20 +1128,6 @@ int net_client_init(Monitor *mon, QemuOpts *opts, int is_netdev) > return -1; > } > > -void net_client_uninit(NICInfo *nd) > -{ > - if (nd->vlan) { > - nd->vlan->nb_guest_devs--; > - } > - nb_nics--; > - > - qemu_free(nd->model); > - qemu_free(nd->name); > - qemu_free(nd->devaddr); > - > - nd->used = 0; > -} > - > static int net_host_check_device(const char *device) > { > int i; > diff --git a/net.h b/net.h > index 116bb80..ecbd812 100644 > --- a/net.h > +++ b/net.h > @@ -163,7 +163,6 @@ extern const char *legacy_tftp_prefix; > extern const char *legacy_bootp_filename; > > int net_client_init(Monitor *mon, QemuOpts *opts, int is_netdev); > -void net_client_uninit(NICInfo *nd); > int net_client_parse(QemuOptsList *opts_list, const char *str); > int net_init_clients(void); > void net_cleanup(void); >