* [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references
@ 2010-02-19 6:43 Jes Sorensen
2010-02-19 9:46 ` [Qemu-devel] " Zachary Amsden
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jes Sorensen @ 2010-02-19 6:43 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Marcelo Tosatti, QEMU Developers, KVM General
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
Hi,
The CR3 caching was never implemented in QEMU and is obsoleted by
NPT/EPT. This patch removes the unused references to it from
target-i386/kvm.c.
Cheers,
Jes
[-- Attachment #2: 0000-qemu-kill-c3-cache.patch --]
[-- Type: text/plain, Size: 642 bytes --]
commit 5ed16687929511d015dd3542c4359cabe170401a
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Fri Feb 19 07:39:56 2010 +0100
Remove all references to KVM_CR3_CACHE as it was never implemented.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 0d08cd5..5d9aecc 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -158,9 +158,6 @@ struct kvm_para_features {
#ifdef KVM_CAP_PV_MMU
{ KVM_CAP_PV_MMU, KVM_FEATURE_MMU_OP },
#endif
-#ifdef KVM_CAP_CR3_CACHE
- { KVM_CAP_CR3_CACHE, KVM_FEATURE_CR3_CACHE },
-#endif
{ -1, -1 }
};
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH] QEMU kill CR3_CACHE references
2010-02-19 6:43 [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references Jes Sorensen
@ 2010-02-19 9:46 ` Zachary Amsden
2010-02-19 20:57 ` [Qemu-devel] " Anthony Liguori
2010-02-21 9:41 ` [Qemu-devel] " Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Zachary Amsden @ 2010-02-19 9:46 UTC (permalink / raw)
To: Jes Sorensen
Cc: Anthony Liguori, Marcelo Tosatti, QEMU Developers, KVM General
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c.
This feature was broken by design. Glad to see it go.
Zach
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references
2010-02-19 6:43 [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references Jes Sorensen
2010-02-19 9:46 ` [Qemu-devel] " Zachary Amsden
@ 2010-02-19 20:57 ` Anthony Liguori
2010-02-21 9:41 ` [Qemu-devel] " Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2010-02-19 20:57 UTC (permalink / raw)
To: Jes Sorensen
Cc: Anthony Liguori, Marcelo Tosatti, QEMU Developers, KVM General
On 02/19/2010 12:43 AM, Jes Sorensen wrote:
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c.
Let's bring this through uq/master? Sound reasonable Marcelo?
Regards,
Anthony Liguori
> Cheers,
> Jes
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] Re: [PATCH] QEMU kill CR3_CACHE references
2010-02-19 6:43 [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references Jes Sorensen
2010-02-19 9:46 ` [Qemu-devel] " Zachary Amsden
2010-02-19 20:57 ` [Qemu-devel] " Anthony Liguori
@ 2010-02-21 9:41 ` Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2010-02-21 9:41 UTC (permalink / raw)
To: Jes Sorensen
Cc: Anthony Liguori, Marcelo Tosatti, QEMU Developers, KVM General
On 02/19/2010 08:43 AM, Jes Sorensen wrote:
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-21 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-19 6:43 [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references Jes Sorensen
2010-02-19 9:46 ` [Qemu-devel] " Zachary Amsden
2010-02-19 20:57 ` [Qemu-devel] " Anthony Liguori
2010-02-21 9:41 ` [Qemu-devel] " Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).