From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiaAK-0004nE-1H for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:13:36 -0500 Received: from [199.232.76.173] (port=50957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiaAJ-0004n2-Hj for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:13:35 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiaAI-0007Ha-9d for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:13:35 -0500 Received: from mail-gx0-f213.google.com ([209.85.217.213]:56010) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiaAI-0007HS-0x for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:13:34 -0500 Received: by gxk5 with SMTP id 5so289782gxk.16 for ; Fri, 19 Feb 2010 13:13:33 -0800 (PST) Message-ID: <4B7EFEFA.60501@codemonkey.ws> Date: Fri, 19 Feb 2010 15:13:30 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block References: <1266250769-5816-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1266250769-5816-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: armbru@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com, hch@lst.de On 02/15/2010 10:19 AM, Kevin Wolf wrote: > The current implementation of alloc_refcount_block and grow_refcount_table has > fundamental problems regarding error handling. There are some places where an > I/O error means that the image is going to be corrupted. I have found that the > only way to fix this is to completely rewrite the thing. > > Just sending as an RFC to the list hasn't generated a lot of comments (to be > precise, not a single one). This is a critical part of qcow2 and needs reviews. > So let's try it another way: People in CC, please give it a review. Sooner or > later some of you will need to do so anyway. > Should I apply this series? I still don't see any review comments. Regards, Anthony Liguori > Kevin Wolf (3): > qcow2: Factor next_refcount_table_size out > qcow2: Rewrite alloc_refcount_block/grow_refcount_table > qcow2: More check for qemu-img check > > block/qcow2-refcount.c | 334 +++++++++++++++++++++++++++++++++++------------- > 1 files changed, 244 insertions(+), 90 deletions(-) > > > > >