From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiaOd-0005TJ-QT for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:28:23 -0500 Received: from [199.232.76.173] (port=36535 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiaOc-0005Qb-TF for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:28:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiaOb-0002RW-Qs for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:28:22 -0500 Received: from mail-yx0-f200.google.com ([209.85.210.200]:55623) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiaOb-0002RM-I9 for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:28:21 -0500 Received: by yxe38 with SMTP id 38so488784yxe.4 for ; Fri, 19 Feb 2010 13:28:20 -0800 (PST) Message-ID: <4B7F0270.3040208@codemonkey.ws> Date: Fri, 19 Feb 2010 15:28:16 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/21] Monitor: Introduce cmd_new_ret() References: <1265853007-27300-1-git-send-email-lcapitulino@redhat.com> <1265853007-27300-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1265853007-27300-2-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, armbru@redhat.com On 02/10/2010 07:49 PM, Luiz Capitulino wrote: > In order to implement the new error handling and debugging > mechanism for command handlers, we need to change the cmd_new() > callback to return a value. > > This commit introduces cmd_new_ret(), which returns a value and > will be used only temporarily to handle the transition from > cmd_new(). > > That is, as soon as all command handlers are ported to cmd_new_ret(), > it will be renamed back to cmd_new() and the new error handling > and debugging mechanism will be added on top of it. > > Signed-off-by: Luiz Capitulino > Applied all. Thanks! Regards, Anthony Liguori