From: Anthony Liguori <anthony@codemonkey.ws>
To: Adam Litke <agl@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command
Date: Fri, 19 Feb 2010 15:47:54 -0600 [thread overview]
Message-ID: <4B7F070A.9010100@codemonkey.ws> (raw)
In-Reply-To: <1266008156.3474.18.camel@aglitke>
On 02/12/2010 02:55 PM, Adam Litke wrote:
> Arghh... Adding missing S-O-B
>
> Hi Anthony. I wonder if there was a problem when importing my async
> command handler patchset. Since the 'balloon' command completes
> immediately, it must call the completion callback before returning.
> That call was missing but is added by the patch below.
>
> Signed-off-by: Adam Litke<agl@us.ibm.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> diff --git a/monitor.c b/monitor.c
> index ae125b8..f94794d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
> return -1;
> }
>
> + cb(opaque, NULL);
> return 0;
> }
>
>
next prev parent reply other threads:[~2010-02-19 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 20:55 [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command Adam Litke
2010-02-16 13:55 ` Daniel P. Berrange
2010-02-19 21:47 ` Anthony Liguori [this message]
2010-02-22 16:51 ` Adam Litke
2010-02-26 20:26 ` Luiz Capitulino
2010-02-26 20:44 ` Adam Litke
2010-03-08 17:05 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2010-02-12 20:14 Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7F070A.9010100@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agl@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).