From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Niahc-00053x-90
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:48:00 -0500
Received: from [199.232.76.173] (port=43098 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Niahb-00053F-KL
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:47:59 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1Niaha-0007Hp-5X
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:47:59 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:34465
	helo=mail-gy0-f45.google.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NiahZ-0007Hd-TL
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 16:47:58 -0500
Received: by gyh4 with SMTP id 4so46232gyh.4
	for <qemu-devel@nongnu.org>; Fri, 19 Feb 2010 13:47:57 -0800 (PST)
Message-ID: <4B7F070A.9010100@codemonkey.ws>
Date: Fri, 19 Feb 2010 15:47:54 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon
	command
References: <1266008156.3474.18.camel@aglitke>
In-Reply-To: <1266008156.3474.18.camel@aglitke>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: qemu-devel@nongnu.org

On 02/12/2010 02:55 PM, Adam Litke wrote:
> Arghh... Adding missing S-O-B
>
> Hi Anthony.  I wonder if there was a problem when importing my async
> command handler patchset.  Since the 'balloon' command completes
> immediately, it must call the completion callback before returning.
> That call was missing but is added by the patch below.
>
> Signed-off-by: Adam Litke<agl@us.ibm.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> diff --git a/monitor.c b/monitor.c
> index ae125b8..f94794d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
>           return -1;
>       }
>
> +    cb(opaque, NULL);
>       return 0;
>   }
>
>