From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Fix segfault during rebase
Date: Fri, 19 Feb 2010 16:01:33 -0600 [thread overview]
Message-ID: <4B7F0A3D.6040908@codemonkey.ws> (raw)
In-Reply-To: <1266406379-5029-1-git-send-email-kwolf@redhat.com>
On 02/17/2010 05:32 AM, Kevin Wolf wrote:
> This fixes a possible read beyond the end of the temporary buffers used for
> comparing data in the old and the new backing file.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-img.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 250d892..258dc62 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1225,7 +1225,7 @@ static int img_rebase(int argc, char **argv)
> int pnum;
>
> if (compare_sectors(buf_old + written * 512,
> - buf_new + written * 512, n,&pnum))
> + buf_new + written * 512, n - written,&pnum))
> {
> ret = bdrv_write(bs, sector + written,
> buf_old + written * 512, pnum);
>
prev parent reply other threads:[~2010-02-19 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 11:32 [Qemu-devel] [PATCH] qemu-img: Fix segfault during rebase Kevin Wolf
2010-02-19 22:01 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7F0A3D.6040908@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).