* [Qemu-devel] [PATCH] qemu-img: Fix error message
@ 2010-02-17 11:33 Kevin Wolf
2010-02-19 22:01 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2010-02-17 11:33 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf
When qemu-img can't open the new backing file for a rebase, it prints an error
message which contains the file name of the old backing file. This is wrong,
obviously.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-img.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index b03b382..250d892 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1169,7 +1169,7 @@ static int img_rebase(int argc, char **argv)
if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS | BDRV_O_RDWR,
new_backing_drv))
{
- error("Could not open new backing file '%s'", backing_name);
+ error("Could not open new backing file '%s'", out_baseimg);
return -1;
}
}
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-img: Fix error message
2010-02-17 11:33 [Qemu-devel] [PATCH] qemu-img: Fix error message Kevin Wolf
@ 2010-02-19 22:01 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-02-19 22:01 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On 02/17/2010 05:33 AM, Kevin Wolf wrote:
> When qemu-img can't open the new backing file for a rebase, it prints an error
> message which contains the file name of the old backing file. This is wrong,
> obviously.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-img.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index b03b382..250d892 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1169,7 +1169,7 @@ static int img_rebase(int argc, char **argv)
> if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS | BDRV_O_RDWR,
> new_backing_drv))
> {
> - error("Could not open new backing file '%s'", backing_name);
> + error("Could not open new backing file '%s'", out_baseimg);
> return -1;
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-19 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-17 11:33 [Qemu-devel] [PATCH] qemu-img: Fix error message Kevin Wolf
2010-02-19 22:01 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).