From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: Frediano Ziglio <freddy77@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.
Date: Fri, 19 Feb 2010 17:26:54 -0600 [thread overview]
Message-ID: <4B7F1E3E.6090908@codemonkey.ws> (raw)
In-Reply-To: <E1B2D4A6-EE80-48C5-8E8D-67EB56436D07@suse.de>
On 02/19/2010 04:22 PM, Alexander Graf wrote:
> On 19.02.2010, at 22:50, Anthony Liguori wrote:
>
>
>> On 02/16/2010 02:35 AM, Frediano Ziglio wrote:
>>
>>> Add a QEMU timer only when needed (timeout status not set, timeout
>>> irq wanted and timer set).
>>>
>>> This patch is required for Darwin. Patch has been tested under
>>> FreeBSD, Darwin and Linux.
>>>
>>> Signed-off-by: Frediano Ziglio<freddy77@gmail.com>
>>>
>>>
>> Alex, I know you've played with this feature for OS X in the past.
>>
>> Is this something we should be enabling unconditionally?
>>
> I've played with it and realized that
>
> 1) OSX's rtl8139 driver uses this timer instead of tx/rx interrupts to process the queue
> 2) it was broken
>
> I haven't gotten around to test if this patch makes it work, but I'd suppose so.
>
> So yes, I think it should be enabled by default. It's a feature real hw has, so we should emulate it.
>
The thing that concerns me is why it was disabled by default. Igor,
what was the reasoning for disabling it if you recall?
Regards,
Anthony Liguori
> Alex
next prev parent reply other threads:[~2010-02-19 23:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 8:35 [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139 Frediano Ziglio
2010-02-19 21:50 ` Anthony Liguori
2010-02-19 22:22 ` Alexander Graf
2010-02-19 23:26 ` Anthony Liguori [this message]
2010-02-20 5:52 ` Igor Kovalenko
2010-02-20 16:14 ` Frediano Ziglio
2010-02-20 16:06 ` Frediano Ziglio
2010-02-20 17:13 ` Anthony Liguori
2010-02-20 17:27 ` Frediano Ziglio
2010-02-25 14:24 ` Paul Brook
2010-02-20 17:50 ` Frediano Ziglio
2010-02-19 23:24 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7F1E3E.6090908@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=freddy77@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).