From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NicFQ-0006Or-Bm
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 18:27:00 -0500
Received: from [199.232.76.173] (port=53866 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NicFP-0006Nl-Ma
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 18:26:59 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NicFO-0000Ch-Da
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 18:26:59 -0500
Received: from mail-gx0-f213.google.com ([209.85.217.213]:56250)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NicFO-0000Cc-5U
	for qemu-devel@nongnu.org; Fri, 19 Feb 2010 18:26:58 -0500
Received: by gxk5 with SMTP id 5so426836gxk.16
	for <qemu-devel@nongnu.org>; Fri, 19 Feb 2010 15:26:57 -0800 (PST)
Message-ID: <4B7F1E3E.6090908@codemonkey.ws>
Date: Fri, 19 Feb 2010 17:26:54 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.
References: <1266309345-2889-1-git-send-email-freddy77@gmail.com>
	<4B7F0796.4000706@codemonkey.ws>
	<E1B2D4A6-EE80-48C5-8E8D-67EB56436D07@suse.de>
In-Reply-To: <E1B2D4A6-EE80-48C5-8E8D-67EB56436D07@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Frediano Ziglio <freddy77@gmail.com>, qemu-devel@nongnu.org

On 02/19/2010 04:22 PM, Alexander Graf wrote:
> On 19.02.2010, at 22:50, Anthony Liguori wrote:
>
>    
>> On 02/16/2010 02:35 AM, Frediano Ziglio wrote:
>>      
>>> Add a QEMU timer only when needed (timeout status not set, timeout
>>> irq wanted and timer set).
>>>
>>> This patch is required for Darwin. Patch has been tested under
>>> FreeBSD, Darwin and Linux.
>>>
>>> Signed-off-by: Frediano Ziglio<freddy77@gmail.com>
>>>
>>>        
>> Alex, I know you've played with this feature for OS X in the past.
>>
>> Is this something we should be enabling unconditionally?
>>      
> I've played with it and realized that
>
> 1) OSX's rtl8139 driver uses this timer instead of tx/rx interrupts to process the queue
> 2) it was broken
>
> I haven't gotten around to test if this patch makes it work, but I'd suppose so.
>
> So yes, I think it should be enabled by default. It's a feature real hw has, so we should emulate it.
>    

The thing that concerns me is why it was disabled by default.  Igor, 
what was the reasoning for disabling it if you recall?

Regards,

Anthony Liguori

> Alex