From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nir6i-0003MR-7G
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 10:19:00 -0500
Received: from [199.232.76.173] (port=35169 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nir6h-0003MB-Py
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 10:18:59 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <daahern@cisco.com>) id 1Nir6g-0008TS-Q9
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 10:18:59 -0500
Received: from sj-iport-6.cisco.com ([171.71.176.117]:58921)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <daahern@cisco.com>) id 1Nir6g-0008Sh-BP
	for qemu-devel@nongnu.org; Sat, 20 Feb 2010 10:18:58 -0500
Message-ID: <4B7FFD5E.7010704@cisco.com>
Date: Sat, 20 Feb 2010 08:18:54 -0700
From: "David S. Ahern" <daahern@cisco.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] terminal attributes is not restored when
	using /dev/tty monitor
References: <20100220083052.GA3582@redhat.com>
In-Reply-To: <20100220083052.GA3582@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shahar Havivi <shaharh@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, qemu-devel@nongnu.org


On 02/20/2010 01:30 AM, Shahar Havivi wrote:
> when exiting qemu that run with "-monitor /dev/tty", the launching
> terminal get weird behaviour because no restore terminals action has
> taken.
> added chr_close and register atexit() code for tty devices (like stdio
> does)
> 
> Signed-off-by: Shahar Havivi <shaharh@redhat.com>
> ---
>  qemu-char.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 75dbf66..de16883 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1002,6 +1002,7 @@ static void tty_serial_init(int fd, int speed,
>             speed, parity, data_bits, stop_bits);
>  #endif
>      tcgetattr (fd, &tty);
> +    oldtty = tty;
>  
>  #define check_speed(val) if (speed <= val) { spd = B##val; break; }
>      speed = speed * 10 / 11;
> @@ -1173,6 +1174,17 @@ static int tty_serial_ioctl(CharDriverState *chr, int cmd, void *arg)
>      return 0;
>  }
>  
> +static void tty_exit(void)
> +{
> +    tcsetattr(0, TCSANOW, &oldtty);
> +}
> +
> +static void qemu_chr_close_tty(struct CharDriverState *chr)
> +{
> +    tty_exit();
> +    fd_chr_close(chr);
> +}


The close callback needs to close the fd for the device as well. I have
sent a patch to handle this; waiting for it to be included:

http://permalink.gmane.org/gmane.comp.emulators.qemu/63472

David


> +
>  static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>  {
>      const char *filename = qemu_opt_get(opts, "path");
> @@ -1190,6 +1202,8 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>          return NULL;
>      }
>      chr->chr_ioctl = tty_serial_ioctl;
> +    chr->chr_close = qemu_chr_close_tty;
> +    atexit(tty_exit);
>      return chr;
>  }
>  #else  /* ! __linux__ && ! __sun__ */