From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nj7tq-0006zG-FW
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:14:50 -0500
Received: from [199.232.76.173] (port=43803 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nj7to-0006z8-W8
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:14:49 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1Nj7to-0008B5-FA
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:14:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29004)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Nj7to-0008Ap-2M
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:14:48 -0500
Message-ID: <4B80F983.7040706@redhat.com>
Date: Sun, 21 Feb 2010 11:14:43 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4B7EC890.8000309@siemens.com>
In-Reply-To: <4B7EC890.8000309@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption
	in kvm mode
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>

On 02/19/2010 07:21 PM, Jan Kiszka wrote:
> This should explain a lot of the weird breakages of upstream KVM we've
> seen recently (actually we should have seen it much earlier):
>
> Stop translating eflags into TCG format when in kvm mode as we never
> translate it back and rather sync this broken state into the kernel.
>
>    

Applied to uq/master and uq/stable-0.12, thanks (though realistically 
0.12 kvm users should stick with qemu-kvm).

> qemu-kvm is not affected as it has it own cpu loop - maybe the way to go
> for upstream as well on the long-term.
>
>    

Or use a skeleton main loop and a function pointer table, like kvm does 
with vmx and svm.

-- 
error compiling committee.c: too many arguments to function