From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nj85c-0008LW-S1
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:27:00 -0500
Received: from [199.232.76.173] (port=59297 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nj85c-0008Kt-IM
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:27:00 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1Nj85b-0001aD-RH
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:27:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11766)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Nj85b-0001Zv-EK
	for qemu-devel@nongnu.org; Sun, 21 Feb 2010 04:26:59 -0500
Message-ID: <4B80FC5F.1020804@redhat.com>
Date: Sun, 21 Feb 2010 11:26:55 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1266603744.git.jan.kiszka@siemens.com>
	<68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com>
In-Reply-To: <68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 8/9] KVM: Rework of guest debug state
	writing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>

On 02/19/2010 08:22 PM, Jan Kiszka wrote:
> So far we synchronized any dirty VCPU state back into the kernel before
> updating the guest debug state. This was a tribute to a deficite in x86
> kernels before 2.6.33. But as this is an arch-dependent issue, it is
> better handle in the x86 part of KVM and remove the writeback point for
> generic code. This also avoids overwriting the flushed state later on if
> user space decides to change some more registers before resuming the
> guest.
>    

Inferring one property of kvm.ko from another is not good, since it 
creates problems with backports.  Better to create a separate KVM_CAP_ 
for the issue you're testing (and we can retroactively apply it to 2.6.33).

-- 
error compiling committee.c: too many arguments to function