From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NjZ9d-0000hd-Bu
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:20:57 -0500
Received: from [199.232.76.173] (port=54674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NjZ9c-0000hU-LY
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:20:56 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <avi@redhat.com>) id 1NjZ9b-0003Wc-T2
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:20:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55922)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NjZ9b-0003WS-Gg
	for qemu-devel@nongnu.org; Mon, 22 Feb 2010 09:20:55 -0500
Message-ID: <4B8292C4.9070802@redhat.com>
Date: Mon, 22 Feb 2010 16:20:52 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20100222135906.347393434@amt.cnet>
	<20100222140209.878250600@amt.cnet>
In-Reply-To: <20100222140209.878250600@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [patch uq/master 1/2] virtio-pci: wake up iothread
	on VIRTIO_PCI_QUEUE_NOTIFY
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 02/22/2010 03:59 PM, Marcelo Tosatti wrote:
> VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers,
> so wakeup the iothread to process that information immediately.
>
> Reported-by: Amit Shah<amit.shah@redhat.com>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> Index: qemu/hw/virtio-pci.c
> ===================================================================
> --- qemu.orig/hw/virtio-pci.c
> +++ qemu/hw/virtio-pci.c
> @@ -204,6 +204,7 @@ static void virtio_ioport_write(void *op
>           break;
>       case VIRTIO_PCI_QUEUE_NOTIFY:
>           virtio_queue_notify(vdev, val);
> +        qemu_notify_event();
>           break;
>    

virtio_queue_notify() will call ->handle_output(), which should either 
do what's needed to be done, or wake up some iothread itself.

-- 
error compiling committee.c: too many arguments to function